Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geo: add st_orientedenvelope builtin #57697

Merged
merged 1 commit into from
Dec 14, 2020
Merged

geo: add st_orientedenvelope builtin #57697

merged 1 commit into from
Dec 14, 2020

Conversation

kakshay21
Copy link
Contributor

@kakshay21 kakshay21 commented Dec 8, 2020 •
edited by otan
Loading

Resolves #49003
Release note (sql change): New builtin method to calculate oriented envelope

@blathers-crl
Copy link

blathers-crl bot commented Dec 8, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Dec 8, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan self-requested a review December 8, 2020 09:17
otan
otan reviewed Dec 8, 2020
View reviewed changes
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey -- thanks! small comments :)

pkg/geo/geomfn/topology_operations.go Outdated Show resolved Hide resolved
pkg/geo/geomfn/topology_operations_test.go Outdated Show resolved Hide resolved
pkg/sql/sem/builtins/geo_builtins.go Outdated Show resolved Hide resolved
@kakshay21 kakshay21 force-pushed the add-oriented-envelope branch from 9936142 to 9852210 Compare December 12, 2020 16:26
@blathers-crl blathers-crl bot requested a review from otan December 12, 2020 16:26
@blathers-crl
Copy link

blathers-crl bot commented Dec 12, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@kakshay21
geo: add st_orientedenvelope builtin
89dc433 
Release note (sql change): New builtin method to calculate oriented envelope
@kakshay21 kakshay21 force-pushed the add-oriented-envelope branch from 9852210 to 89dc433 Compare December 12, 2020 18:12
@kakshay21
Copy link
Contributor Author

Hey @otan
I’ve updated the PR, please review when you can.

@otan
Copy link
Contributor

otan commented Dec 14, 2020 •
edited
Loading

i am away until next year unfortunately, i'll get to it then!

have a good holiday break :) !

otan
otan approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm i have the time

looks good!

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 14, 2020

Build succeeded:

@craig craig bot merged commit cea9423 into cockroachdb:master Dec 14, 2020
@kakshay21 kakshay21 deleted the add-oriented-envelope branch December 15, 2020 09:03
@kakshay21
Copy link
Contributor Author

have a great holiday!

@jseldess jseldess mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

Assignees
No one assigned
Labels
O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_OrientedEnvelope({geometry})
3 participants
@kakshay21 @cockroach-teamcity @otan