jobs: invert status predicate to improve query plan #57587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
The jobs code regularly scans the set of adoptable jobs (generally small) to find if there are abandoned jobs in need of adoption. In cockroachdb#56864 we added a predicate to improve these loops to stop touching already terminal jobs. This was a big improvement in what data is written but not as big of an improvement in what data was read. When the jobs table is large, the queries, prior to this patch, performed expensive full table scans. With this patch the query plan is improved to utilize the index. Were there a check constraint indicating the allowable values of status, then the optimizer could have created the same plan. However, there isn't. Release note (bug fix): Remove system.jobs full table scan which is expensive in the face of many completed jobs.
ajwerner
force-pushed
the
ajwerner/flip-predicates-for-adoption-loop
branch
from
c0c735c to
e1c79f2
Compare
spaskob
approved these changes
Dec 5, 2020
|
TFTR! bors r=spaskob |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jobs code regularly scans the set of adoptable jobs (generally small) to
find if there are abandoned jobs in need of adoption. In #56864 we added a
predicate to improve these loops to stop touching already terminal jobs. This
was a big improvement in what data is written but not as big of an improvement
in what data was read. When the jobs table is large, the queries, prior to this
patch, performed expensive full table scans. With this patch the query plan is
improved to utilize the index. Were there a check constraint indicating the
allowable values of status, then the optimizer could have created the same
plan. However, there isn't.
Release note (bug fix): Remove system.jobs full table scan which is
expensive in the face of many completed jobs.