Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: implement regr_avgy #57583

Merged
merged 1 commit into from
Dec 8, 2020
Merged

builtins: implement regr_avgy #57583

merged 1 commit into from
Dec 8, 2020

Conversation

mneverov
Copy link
Contributor

@mneverov mneverov commented Dec 4, 2020

builtins: implement regr_avgy

Fixes: #41274

Release note (sql change): implement regr_avgy aggregation function.

@mneverov mneverov requested a review from a team as a code owner December 4, 2020 20:10
@blathers-crl
Copy link

blathers-crl bot commented Dec 4, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Dec 4, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Dec 5, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@yuzefovich yuzefovich self-requested a review December 6, 2020 04:18
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :lgtm:

nit: you could adjust the PR description (or the commit message) from See #41274 to something like Fixes: #41274 so that when the PR merges, the issue is closed automatically since regr_avgy is the last aggregate in that issue.

Thanks a lot for your work!

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mneverov)


pkg/sql/opt/operator.go, line 324 at r1 (raw file):

		VarPopOp, CovarPopOp, CovarSampOp, RegressionAvgXOp, RegressionInterceptOp,
		RegressionR2Op, RegressionSlopeOp, RegressionSXXOp, RegressionSXYOp,
		RegressionSYYOp, RegressionCountOp, RegressionAvgYOp:

super nit: it'd be nice to have AvgY and AvgX right next to each other.

Fixes: cockroachdb#41274

Release note (sql change): implement regr_avgy aggregation function.
Copy link
Contributor Author

@mneverov mneverov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yuzefovich , thanks for the amazing support and patience :)!

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @mneverov and @yuzefovich)

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r=yuzefovich

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale)

@craig
Copy link
Contributor

craig bot commented Dec 8, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: Support aggregate functions for statistics
3 participants