release-20.1: opt: fix bug in ExtractJoinEqualities rule #57536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the join is semi/anti, this rule generates an incorrect projection (which passes through columns not in input). Similar to cockroachdb#57501. Other normalization rules prune the columns so this doesn't lead to a bad outcome (at least in most cases). I will add an assertion in CheckExpr for this condition in a separate PR - without this fix, the assertion fires on an existing test. Release note: None
|
This change is |
rytaft
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #57524.
/cc @cockroachdb/release
If the join is semi/anti, this rule generates an incorrect projection
(which passes through columns not in input).
Similar to #57501. Other normalization rules prune the columns so this
doesn't lead to a bad outcome (at least in most cases).
I will add an assertion in CheckExpr for this condition in a separate
PR - without this fix, the assertion fires on an existing test.
Release note: None