util/log: de-flake TestSecondaryGC and some SQL tests #57454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GC daemon was performing an unconditional round of deletion, asynchronously with the start of the test. This was causing a race condition. Release note: None
|
This change is |
As discussed previously in cockroachdb#57222 - the SQL servers do not obey the server stop logic well and leak goroutines that continue to log while the TestLogScope gets closed. This commit continues to tolerate this misdesign by ensuring that some more stderr-related flags are accessed atomically. Release note: None
knz
changed the title
irfansharif
approved these changes
Dec 3, 2020
|
thanks! bors r=irfansharif |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57442
Fixes #57444
See individual commits for details.