Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: Add missing gossiped StoreDescriptor to expected relocate errors #57272

Merged
merged 1 commit into from
Dec 3, 2020
Merged

roachtest: Add missing gossiped StoreDescriptor to expected relocate errors #57272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/kv/test_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ func OnlyFollowerReads(rec tracing.Recording) bool {
// IsExpectedRelocateError maintains an allowlist of errors related to
// atomic-replication-changes we want to ignore / retry on for tests.
// See:
// https://github.com/cockroachdb/cockroach/issues/33732
// https://github.com/cockroachdb/cockroach/issues/33708
// https://github.cm/cockroachdb/cockroach/issues/34012
// https://github.com/cockroachdb/cockroach/issues/33683#issuecomment-454889149
Expand All @@ -53,6 +52,7 @@ func IsExpectedRelocateError(err error) bool {
"snapshot failed:",
"breaker open",
"unable to select removal target", // https://github.com/cockroachdb/cockroach/issues/49513
"cannot up-replicate to .*; missing gossiped StoreDescriptor",
}
pattern := "(" + strings.Join(allowlist, "|") + ")"
return testutils.IsError(err, pattern)
Expand Down