docs: edit release note for schema change feature flag #57143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
probably put that this is a typo on the release note itself. otherwise the script that aggregates this doesn't see that it's a correction |
Release note (sql change): This is an empty commit meant to correct a mistake in a merged release note in cockroachdb#57040. The original release note indicates that a database administrator should toggle this feature flag on and off using SET CLUSTER SETTING feature.schemachange.enabled, but there should be a '_' character so that the cluster setting would be: SET CLUSTER SETTING feature.schema_change.enabled. Below is the full original release note, with the typo fixed. Release note (sql change): Adds a feature flag via cluster setting for all schema change-related features. If a user attempts to use these features while they are disabled, an error indicating that the database administrator has disabled the feature is surfaced. Example usage for the database administrator: SET CLUSTER SETTING feature.schema_change.enabled = FALSE; SET CLUSTER SETTING feature.schema_change.enabled = TRUE;
angelapwen
force-pushed
the
amend-schema-feature-flag-release-note
branch
from
2e1ea02 to
b97c9fb
Compare
Good point! Done. |
otan
approved these changes
Nov 26, 2020
|
bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (sql change): This is an empty commit meant to correct
a mistake in a merged release note in #57040. The original release
note indicates that a database administrator should toggle this
feature flag on and off using
SET CLUSTER SETTING feature.schemachange.enabled, but there
should be a '_' character so that the cluster setting would be:
SET CLUSTER SETTING feature.schema_change.enabled.
Below is the full original release note, with the typo fixed.
Release note (sql change): Adds a feature flag via cluster setting
for all schema change-related features. If a user attempts
to use these features while they are disabled, an error indicating
that the database administrator has disabled the feature is
surfaced.
Example usage for the database administrator:
SET CLUSTER SETTING feature.schema_change.enabled = FALSE;
SET CLUSTER SETTING feature.schema_change.enabled = TRUE;