roachtest: update pgjdbc blocklists #57081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
requested changes
Nov 24, 2020
| "org.postgresql.test.core.LogServerMessagePropertyTest.testWithExplicitlyEnabled": "expected fail - checks error message", | ||
| "org.postgresql.test.core.LogServerMessagePropertyTest.testWithLogServerErrorDetailDisabled": "expected fail - checks error message", | ||
| } | ||
| var pgjdbcIgnoreList19_2 = pgjdbcIgnoreList19_1 | ||
|
|
||
| var pgjdbcIgnoreList19_1 = blocklist{ |
There was a problem hiding this comment.
we can remove 19.1 here and just keep the blocklist for 19.2 and up
There was a problem hiding this comment.
Done. I got rid of all the <19.2 lists.
I made the following updates to the pgjdbc blocklists: - Removed tests which are now passing due to user-defined schema support. - Removed testUpdateSelectOnly since we now support this syntax as a no-op. - Updated some failure reasons to "unknown" for tests which are still failing even though the referenced issue was closed. - Added many BatchExecuteTest.* tests to the ignore list. These tests are flaky due to a combination of cockroachdb#54477 and the fact that the tests do not run in a deterministic order. - Removed lists for versions earlier than v19.2. Fixes cockroachdb#53467 Fixes cockroachdb#53738 Fixes cockroachdb#54106 Release note: None
solongordon
force-pushed
the
fix-pgjdbc-tests
branch
from
3d8e39a to
4f071aa
Compare
|
Thanks for the heads up about backports! |
rafiss
approved these changes
Nov 24, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the following updates to the pgjdbc blocklists:
support.
no-op.
failing even though the referenced issue was closed.
are flaky due to a combination of sql: cannot perform schema change in transaction after write #54477 and the fact that the tests
do not run in a deterministic order.
Fixes #53467
Fixes #53738
Fixes #54106
Release note: None