sql: move ComponentStats to execinfrapb #56842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proto belongs in execinfrapb. For example, we should be able to store ProcessorID/StreamIDs in it if necessary. The differences in the proto file are due to proto2/proto3. The DistSQL version doesn't need bumping, the messages are different (because of the package change) and unknown messages will just be ignored. Release note: None
|
This change is |
yuzefovich
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
I assume that the logic tests will need to be updated, but the change
Reviewed 35 of 35 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
RaduBerinde
commented
Nov 18, 2020
There was a problem hiding this comment.
TFTR! Why would logic tests need updating? Functionally nothing should change.
Reviewable status:
|
I thought that encoding would change because of proto3 and proto2 change 🤷 |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proto belongs in execinfrapb. For example, we should be able to
store ProcessorID/StreamIDs in it if necessary.
The differences in the proto file are due to proto2/proto3. The
DistSQL version doesn't need bumping, the messages are different
(because of the package change) and unknown messages will just be
ignored.
Release note: None