-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jepsen: ignore some install errors #56815
jepsen: ignore some install errors #56815
Conversation
c44776d
to
3ac636a
Compare
070c415
to
99b0bf9
Compare
No objection for me - but I would like to highlight this is one more test that is too happy to go and fetch dependencies externally. Why don't we have our own local copies of these files? cc @jlinder - what would be the better fix here? |
LGTM Andrei has long been beating the drum about making these self-contained, but we haven't had the resources to do it. Once we build abstractions here, they need to be maintained, and so unless dev-inf can take this on I think we'll just have to live with the status quo. |
Dev-inf hasn't had time to focus on roachtest since before July and won't until next year sometime.
The most obvious fix that doesn't download the file from the source location on every run is:
If there are files loaded by the runs in AWS, add this to the above:
|
Added an issue to track this feature request. #56856 |
99b0bf9
to
c8cc365
Compare
We'll want to backport this as well, as we've also seen this failure on other release branches: https://github.com/cockroachdb/cockroach/issues?q=is%3Aissue+is%3Aopen+%22If+you+are+behind+a+proxy%2C+try+setting+the+%27http_proxy%27+environment+variable.%22. |
6e54539
to
06e75f5
Compare
Two failures. Seem to have been transient. ``` | Could not transfer artifact org.clojure:clojure:jar:1.9.0 from/to central (https://repo1.maven.org/maven2/): GET request of: org/clojure/clojure/1.9.0/clojure-1.9.0.jar from central failed | Could not find artifact org.clojure:clojure:jar:1.9.0 in clojars (https://repo.clojars.org/) | This could be due to a typo in :dependencies, file system permissions, or network issues. | If you are behind a proxy, try setting the 'http_proxy' environment variable. ``` ``` | Failed to read artifact descriptor for commons-codec:commons-codec:jar:1.6 | This could be due to a typo in :dependencies, file system permissions, or network issues. ``` Fixes cockroachdb#56695 Fixes cockroachdb#56645 Fixes cockroachdb#56644 Fixes cockroachdb#56565 Fixes cockroachdb#56519 Release note: None
06e75f5
to
efd1cbb
Compare
bors r+ |
Build succeeded: |
Two failures. Seem to have been transient.
Fixes #56695
Fixes #56645
Release note: None