Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

licenses: add LGPL license for GEOS #56376

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

otan
Copy link
Contributor

@otan otan commented Nov 6, 2020

Release note: None

@otan otan requested review from bdarnell and jlinder November 6, 2020 18:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename should be LGPL.txt, not LGPL-libgeos.txt (the reason we have per-project files like BSD-*.txt is that these licenses are not actually identical, but the LGPL is more standardized than the BSD/MIT families)

I wonder if we should include a more explicit mapping of component to license in this directory (especially when it comes to the line between copyleft and the permissive licenses that cover nearly all of our dependencies).

@otan otan force-pushed the add_geos_license branch from 0c8cd67 to 97f48f6 Compare November 9, 2020 14:44
@otan
Copy link
Contributor Author

otan commented Nov 9, 2020

thanks! changes made!

bors r=jlinder,bdarnell

@otan
Copy link
Contributor Author

otan commented Nov 9, 2020

I wonder if we should include a more explicit mapping of component to license in this directory (especially when it comes to the line between copyleft and the permissive licenses that cover nearly all of our dependencies).

probably more worthwhile at some point!

@craig
Copy link
Contributor

craig bot commented Nov 9, 2020

Build succeeded:

@craig craig bot merged commit b594a7f into cockroachdb:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants