sql: refactor code shared by diagnostics and EXPLAIN ANALYZE (DEBUG) #56262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
minor-refactors
branch
from
9ca086a to
e532bb6
Compare
Pass the recording instead of the span. Release note: None
RaduBerinde
force-pushed
the
minor-refactors
branch
from
e532bb6 to
988d93a
Compare
andreimatei
reviewed
Nov 4, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @andreimatei)
There are two paths that result in a bundle being collected and inserted into the diagnostics tables. Each path uses its own code to insert the diagnostics bundle, which leads to unnecessary complication. This change simplifies the stmtdiagnostics code to let the caller do the insertion and streamlines the higher level code. Release note: None
RaduBerinde
force-pushed
the
minor-refactors
branch
from
988d93a to
789d3f8
Compare
|
bors r+ |
|
Build failed: |
|
Looks like a couple of flaky tests. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 5, 2020
56262: sql: refactor code shared by diagnostics and EXPLAIN ANALYZE (DEBUG) r=RaduBerinde a=RaduBerinde #### sql: pass recording to WithStatementTrace Pass the recording instead of the span. Release note: None #### sql: refactor code shared by diagnostics and EXPLAIN ANALYZE (DEBUG) There are two paths that result in a bundle being collected and inserted into the diagnostics tables. Each path uses its own code to insert the diagnostics bundle, which leads to unnecessary complication. This change simplifies the stmtdiagnostics code to let the caller do the insertion and streamlines the higher level code. Release note: None Co-authored-by: Radu Berinde <[email protected]>
|
Build failed: |
|
Hit #56283 bors r+ |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Nov 6, 2020
56286: sql: refactor instrumentation of query execution r=RaduBerinde a=RaduBerinde Note: this PR covers only the two top commits; the others are #56262. #### sql: refactor instrumentation of query execution This change separates the code around setting up tracing and collecting bundles into a new instrumentationHelper. The intention is that more related logic (like collecting plans for the UI) will be incorporated. Release note: None #### sql: move more logic into instrumentationHelper This commit moves the logic around collecting explain plans (for bundles and for UI) into `instrumentationHelper`. Release note: None Co-authored-by: Radu Berinde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: pass recording to WithStatementTrace
Pass the recording instead of the span.
Release note: None
sql: refactor code shared by diagnostics and EXPLAIN ANALYZE (DEBUG)
There are two paths that result in a bundle being collected and inserted
into the diagnostics tables. Each path uses its own code to insert the
diagnostics bundle, which leads to unnecessary complication.
This change simplifies the stmtdiagnostics code to let the caller do
the insertion and streamlines the higher level code.
Release note: None