sql: ban alter column type on view-depended cols #56213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
thoszhang
approved these changes
Nov 3, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
otan
approved these changes
Nov 3, 2020
Previously, it was legal to edit the column type of columns that were depended on by views. This is not a good idea for various reasons, and is not Postgres compatible to boot. Now, it is illegal to alter the column type of columns that are depended on views. Release note (sql change): prevent column type modification of columns that are depended on by views.
jordanlewis
force-pushed
the
act-views
branch
from
dde0158 to
bc642d0
Compare
|
Thanks for the reviews! bors r+ |
|
Build failed: |
|
Failed due to flaky test that should be fixed by #56265, courtesy borsing. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was legal to edit the column type of columns that were
depended on by views. This is not a good idea for various reasons, and
is not Postgres compatible to boot.
Now, it is illegal to alter the column type of columns that are depended
on views.
Closes #56166.
Release note (sql change): prevent column type modification of columns
that are depended on by views.