sqlliveness/sqlstorage: fix flakey test #55977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a flakey test introduced in cockroachdb#55524. The flake is that we unconditionally start the slstorage subsystem before we sometimes override some of its settings. This change makes each subtest start the storage individually. Fixes cockroachdb#55964. Release note: None
|
This change is |
spaskob
reviewed
Oct 26, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @spaskob)
|
TFTR! bors r=spaskob |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a flakey test introduced in #55524. The flake is that
we unconditionally start the slstorage subsystem before we sometimes
override some of its settings. This change makes each subtest start
the storage individually.
Fixes #55964.
Release note: None