release-20.2: backupccl: only restore system tables included in backup #55719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including the cluster version in cluster restore might decrease the cluster version. We have seen this cause issues where DROP DATABASES stop working. Release note: None
Before this commit, we would assume that all of the system tables that we wanted to restore were present in the backup. However, this is not necessarily true since system tables can be added between releases. Release note (bug fix): Previously cluster backups taken from before 20.2 could not be restored in 20.2 clusters, with an error message about failing to restore a system table. This is now fixed.
|
This change is |
dt
approved these changes
Oct 20, 2020
|
Looks like the first CI run flaked on #55718, re-running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #55685.
/cc @cockroachdb/release
Before this commit, we would assume that all of the system tables that
we wanted to restore were present in the backup. However, this is not
necessarily true since system tables can be added between releases.
Release note (bug fix): Previously cluster backups taken from before
20.2 could not be restored in 20.2 clusters, with an error message about
failing to restore a system table. This is now fixed.