Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colexec: clean up min_max template #55663

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

yuzefovich
Copy link
Member

We have recently removed some custom logic with min/max aggregate
templates because they are now correctly typed, and this allows us to
clean up the template a bit.

Release note: None

We have recently removed some custom logic with min/max aggregate
templates because they are now correctly typed, and this allows us to
clean up the template a bit.

Release note: None
@yuzefovich yuzefovich requested review from asubiotto and a team October 17, 2020 17:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: nice

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 19, 2020

Build succeeded:

@craig craig bot merged commit 3e3aaf3 into cockroachdb:master Oct 19, 2020
@yuzefovich yuzefovich deleted the cleanup-min-max branch October 19, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants