release-20.2: workload/tpcc: properly partition order.order_idx index #55639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were quoting the table name in order to avoid clashing with the reserved keyword, but this was tripping up the index existence check. We were then silently swallowing this error. This meant that the table was not properly partitioned, which likely had a large negative impact on New-Order transactions, which insert into the table. While here, remove references to the three indexes deleted in cockroachdb#52931. Release justification: testing only.
|
This change is |
aayushshah15
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @aayushshah15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #54064.
/cc @cockroachdb/release
Spotted by @drewdeally.
We were quoting the table name in order to avoid clashing with the
reserved keyword, but this was tripping up the index existence check.
We were then silently swallowing this error. This meant that the table
was not properly partitioned, which likely had a large negative impact
on New-Order transactions, which insert into the table.
While here, remove references to the three indexes deleted in #52931.
Release justification: testing only.