backupccl: deflake a test #55526
Merged
backupccl: deflake a test #55526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
requested review from
thoszhang,
a team and
dt
and removed request for
a team
|
This change is |
|
Here is an example of the failure. |
thoszhang
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Thanks!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt)
I've just hit a test flake on one of my branches because the order of the schemas in the output was different from the expected one which appears to be due to the queries not having an ORDER BY clause. That is now fixed which should make the test output deterministic. Release note: None
|
TFTR! bors r+ |
|
Just FYI - it seems like the test output might have been changing only because of the changes to the hash join algorithm that are part of #54808. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just hit a test flake on one of my branches because the order of the
schemas in the output was different from the expected one which appears
to be due to the queries not having an ORDER BY clause. That is now
fixed which should make the test output deterministic.
Release note: None