Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: Implement ST_AsEncodedPolyline function #55515

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

mknycha
Copy link
Contributor

@mknycha mknycha commented Oct 13, 2020

This function takes the geometry and precision and returns the encoded polyline ASCII.
Works the same as in PostGIS.
Release note (sql change): Implement geo builtin ST_AsEncodedPolyline

Resolves #48872

This function takes the geometry and precision and returns the encoded polyline ASCII.
Works the same as in PostGIS.
Release note (sql change): Implement geo builtin ST_AsEncodedPolyline
@blathers-crl
Copy link

blathers-crl bot commented Oct 13, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels Oct 13, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mknycha
Copy link
Contributor Author

mknycha commented Oct 13, 2020

@otan could you please review or assign someone else?

@otan
Copy link
Contributor

otan commented Oct 13, 2020

yep! please put the issue number in the PR description, so that it automatically tags me.

@otan otan self-requested a review October 13, 2020 21:56
@otan
Copy link
Contributor

otan commented Oct 13, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 13, 2020

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 14, 2020

Build succeeded:

@craig craig bot merged commit 05826e3 into cockroachdb:master Oct 14, 2020
@mknycha
Copy link
Contributor Author

mknycha commented Oct 14, 2020

yep! please put the issue number in the PR description, so that it automatically tags me.

Sorry, I forgot. I'll remember next time

@mknycha mknycha deleted the implement-st-as-encoded-polyline branch October 14, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geo/geomfn: implement ST_AsEncodedPolyline({geometry,int4})
3 participants