Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: bugfix to vtable lookup joins #55212

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

jordanlewis
Copy link
Member

@jordanlewis jordanlewis commented Oct 3, 2020

Previously, vtable lookup joins had a memory aliasing bug that could
cause incorrect results in some circumstances. This bug is now fixed.

Fixes #55140

Release note (bug fix): prevent a crash in prerelease 20.2 binaries in
plans that use the new virtual table lookup join feature.

Previously, vtable lookup joins had a memory aliasing bug that could
cause incorrect results in some circumstances. This bug is now fixed.

Release note (bug fix): prevent a crash in prerelease 20.2 binaries in
plans that use the new virtual table lookup join feature.
@jordanlewis jordanlewis requested review from rafiss and a team October 3, 2020 16:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis
Copy link
Member Author

Needs a test.

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful find!

@jordanlewis
Copy link
Member Author

I'm going to merge this now. It's hard to test, but #55223 will test it when merged.

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 8, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: 100x performance degradation in pgjdbc query to fetch columns
3 participants