opt: improve various composite-ness checks

[RaduBerinde]

opt: improve composite check for PushFilterIntoSetOp

Use CanBeCompositeSensitive instead of disallowing any filters
involving composite columns.

Release note: None

opt: improve composite check for Project FDs

Release note: None

opt: improve composite check for join filter remapping

Use CanBeCompositeSensitive to allow remapping insensitive join
filters.

Release note: None

[cockroach-teamcity]

This change is 

[rytaft]

Reviewed 2 of 2 files at r1, 11 of 11 files at r2, 2 of 2 files at r3.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @RaduBerinde)

---

pkg/sql/opt/norm/join_funcs.go, line 337 at r3 (raw file):

	allowCompositeEncoding := !memo.CanBeCompositeSensitive(c.mem.Metadata(), src)
	// Map each column in src to one column in dst. We choose an arbitrary column

[nit] add a blank line above this

---

pkg/sql/opt/norm/join_funcs.go, line 408 at r3 (raw file):

//
// TODO(rytaft): In the future, we may want to allow the mapping if the
// filter involves a comparison operator, such as x < 5.

you can remove this TODO :)
(and update the comment)

[RaduBerinde]

TFTR!

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @rytaft)

---

pkg/sql/opt/norm/join_funcs.go, line 337 at r3 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

[nit] add a blank line above this

Done.

---

pkg/sql/opt/norm/join_funcs.go, line 408 at r3 (raw file):

Previously, rytaft (Rebecca Taft) wrote…

you can remove this TODO :)
(and update the comment)

Nice catch, done!

[rytaft]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @mgartner)

[RaduBerinde]

bors r+

[craig]

Build failed (retrying...):

• GitHub CI (Cockroach)

[craig]

Build succeeded:

• GitHub CI (Cockroach)