Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: doctor check for dropped tables #55109

Merged
merged 1 commit into from
Oct 2, 2020
Merged

sql: doctor check for dropped tables #55109

merged 1 commit into from
Oct 2, 2020

Conversation

spaskob
Copy link
Contributor

@spaskob spaskob commented Oct 1, 2020

If a table is dropped it should not have a namespace entry.

Release note: none.

@spaskob spaskob requested a review from ajwerner October 1, 2020 09:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

sql: doctor check for dropped tables
c0404a5 
If a table is dropped it should not have a namespace entry.

Release note: none.
ajwerner
ajwerner approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@spaskob
Copy link
Contributor Author

spaskob commented Oct 2, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 2, 2020

Build succeeded:

@craig craig bot merged commit 411cb5b into cockroachdb:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaskob @cockroach-teamcity @ajwerner