Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: roachtest: add schemachange/database-version-upgrade #54956

Closed

Conversation

thoszhang
Copy link
Contributor

Backport 1/1 commits from #54489.

/cc @cockroachdb/release


This PR adds a new mixed-version roachtest, which tests 2 loosely
related things:

  1. Correctness of database schema changes during the 20.1/20.2 mixed-
    version state, in which 20.2 nodes still use the deprecated database
    cache and non-lease-based schema change implementation.
  2. Ability to use ALTER DATABASE ... CONVERT TO SCHEMA WITH PARENT on
    databases created in 20.1.

To these ends, the test creates several databases, runs schema changes
on each one at different states in the rolling upgrade process, and runs
the reparenting statement on all of them post-finalization.

Closes #53568.

Release note: None

This PR adds a new mixed-version roachtest, which tests 2 loosely
related things:

1. Correctness of database schema changes during the 20.1/20.2 mixed-
   version state, in which 20.2 nodes still use the deprecated database
   cache and non-lease-based schema change implementation.
2. Ability to use ALTER DATABASE ... CONVERT TO SCHEMA WITH PARENT on
   databases created in 20.1.

To these ends, the test creates several databases, runs schema changes
on each one at different states in the rolling upgrade process, and runs
the reparenting statement on all of them post-finalization.

Release note: None
@thoszhang thoszhang requested a review from ajwerner September 29, 2020 16:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@thoszhang
Copy link
Contributor Author

I was just reminded that we always use roachtest from the master branch (for now...), so this isn't necessary.

@thoszhang thoszhang closed this Oct 6, 2020
@thoszhang thoszhang deleted the backport20.2-54489 branch October 6, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants