release-19.2: build: bump timeout for SQL Race Logic tests to 4 hours #54789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit increases the test timeout to 1 hour, since the tests have been failing by timing out after 30 minutes. We may need to increase the timeout further, but this is a start. Release note: None
The test is still timing out after 2 hours, so this commit bumps the timeout to 4 hours. Release note: None
|
This change is |
asubiotto
approved these changes
Sep 25, 2020
|
Yea, we weren't running these before, but I'm not sure why. I added this test to TeamCity about a week ago (not sure if it was there before but removed?) because we want to run the different randomized configurations (the second two commands in this file) that will test disabling certain rules or selecting different query plans due to a different cost. It would be best if we could run them with the race configuration because we perform additional checks in the optimizer during race builds, but if need be maybe we could just add a build flag that enables the checks without running a race build. Seems like there might be value in running the logic tests under the race build, though, since you identified #54685... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release