Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtins: add unimplemented errors for full text search builtins #54573

Merged
merged 1 commit into from
Sep 18, 2020
Merged

builtins: add unimplemented errors for full text search builtins #54573

merged 1 commit into from
Sep 18, 2020

Conversation

otan
Copy link
Contributor

@otan otan commented Sep 18, 2020

Refs: #7821, #51424

Release note: None

@otan otan requested review from arulajmani and a team September 18, 2020 16:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

arulajmani
arulajmani requested changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @arulajmani and @otan)

pkg/sql/sem/builtins/builtins.go, line 2867 at r1 (raw file):

	"json_to_tsvector":     makeBuiltin(tree.FunctionProperties{UnsupportedWithIssue: 7821, Category: categoryFullTextSearch}),
	"jsonb_to_tsvector":    makeBuiltin(tree.FunctionProperties{UnsupportedWithIssue: 7821, Category: categoryFullTextSearch}),
	"phraseto_tsquery":     makeBuiltin(tree.FunctionProperties{UnsupportedWithIssue: 7821, Category: categoryFullTextSearch}),

This list doesn't seem to include all the functions from https://www.postgresql.org/docs/12/functions-textsearch.html. Is that intentional?

@otan
Copy link
Contributor Author

otan commented Sep 18, 2020

pkg/sql/sem/builtins/builtins.go, line 2867 at r1 (raw file):

Previously, arulajmani (Arul Ajmani) wrote…

This list doesn't seem to include all the functions from https://www.postgresql.org/docs/12/functions-textsearch.html. Is that intentional?

ok, missed a few with my pgproc query. fixed now!

arulajmani
arulajmani approved these changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)

@otan
Copy link
Contributor Author

otan commented Sep 18, 2020

tftr!

bors r=arulajmani

@craig
Copy link
Contributor

craig bot commented Sep 18, 2020

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 18, 2020

Build succeeded:

@craig craig bot merged commit d0f3bfd into cockroachdb:master Sep 18, 2020
@otan otan mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arulajmani arulajmani arulajmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otan @cockroach-teamcity @arulajmani