-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: re-skip two bank tests #53833
Conversation
This has since incurred two more failures on merge-to-master, so going ahead with a self-review on behalf of test infra team bors r+ |
Build failed: |
bors r+ Needed a release justification on the PR description as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you use a comment in the second line instead of a skip
directive
I simply reverted the commits. I agree that a skip directive would have been better, this isn't worth another turnaround. I could imagine (have not checked) that this test has been skipped for longer than the skip directive existed. |
In fact you added the |
Build succeeded: |
They hit flakes: #53829
In particular, there seems to be a fatal on an untracked goroutine, which causes roachtest to terminate prematurely.
Release justification: testing
Release note: None