deps: bump cockroachdb/errors and cockroachdb/redact #53764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
irfansharif
approved these changes
Sep 1, 2020
knz
force-pushed
the
20200901-bump-errors
branch
2 times, most recently
from
ccdf1a6 to
8707ea6
Compare
knz
force-pushed
the
20200901-bump-errors
branch
2 times, most recently
from
d55f54f to
00a3932
Compare
This picks up improved support for `%T` in format strings, as well as better support for `%w`. Release justification: low risk, high benefit changes to existing functionality Release note: None
Prior to this patch, `colexecerror.InternalError()` would take any
type as input. This was encouraging callers to pass not only constant
strings and errors, it was also encouraging uses of `fmt.Sprintf`
However, given that these errors ultimately make their way to crash
reporting, we really want as much details as possible in crash
reports. Simple strings don't cut it and are considered fully unsafe
for reporting.
What we want instead if a discrete separation of safe and unsafe
details. The machinery to do this is available in the `redact`
package, but for ease of use the `errors` library also does it.
So this patch changes `InternalError()` to require an `error`
argument, and invokes `errors.AssertionFailedf` or `log.PanicAsError`
in the call points.
This API can be further simplified in the future by making
`InternalError`
responsible for constructing the error object, for example
```go
InternalErrorf(format string, args ...interface{}) {
panic(errors.AssertionFailedf(format, args...))
}
```
This improvement is left for a later change though.
Release justification: low risk, high benefit changes to existing functionality
Release note: None
Error objects in panics allow us to expose more safe details for telemetry reporting. Release justification: low risk, high benefit changes to existing functionality Release note: None
knz
force-pushed
the
20200901-bump-errors
branch
from
00a3932 to
fea562b
Compare
|
bors r=irfansharif |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Sep 2, 2020
53312: server,pgwire: make more log message bits non-redactable r=spaskob,irfansharif a=knz Commit prefix from #53764 see individual commits for details Release justification: low risk, high benefit changes to existing functionality 53650: sql: allow non-admins to perform some RESTOREs r=solongordon a=solongordon Release justification: Low risk, high reward change to existing functionality Release note (sql change): Non-admin users are now permitted to execute RESTORE statements as long as the restore does not depend on implicit credentials and the user has the appropriate privileges to create all of the resulting database objects. For database restores, this means the user must have the CREATEDB role privilege. For table restores, the user must have CREATE privileges on the parent database. Full cluster restores still require admin privileges. Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Solon Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53207
Fixes #53700
Needed for #53312
This picks up improved support for
%Tin format strings,as well as better support for
%w.Release justification: low risk, high benefit changes to existing functionality
Release note: None