cli/interactive_tests: de-flake test_missing_log_output #53408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (cli change): The command-line flag `--socket` has been removed. It was deprecated since v20.1. Use `--socket-dir` in replacement.
|
This change is |
tbg
approved these changes
Aug 25, 2020
Release note (cli change): The command-line `--insecure` has been marked as deprecated. See https://go.crdb.dev/issue/53404 for details. The flag will be removed in a later version in a staged fashion: first, additional security mechanisms will be added to enable more flexible deployments which were previously done using `--insecure`; then the flaf will be removed from server commands, then finally in a later version also from client commands.
This flake was introduced in a recent bump of `cockroachdb/errors`, combined with cockroachdb#52201. Release note: None
|
bors r=tbg |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
bors r- this did not fix the issue apparently |
|
Canceled. |
|
We've addressed this since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50970
This flake was introduced in a recent bump of
cockroachdb/errors,combined with #52201.
Release note: None