log,demo: minor refactor and simplification #53313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
The demo code was trying a complicated dance with the flag structs to disable logging. This was not necessary - a simple adjustment of the advertised store config is sufficient to reach the desired effect. Additionally, this commit provides a hint to the user if they want to enable redaction markers but there is no logging dir yet. Release note: None
|
This change is |
rohany
approved these changes
Aug 24, 2020
|
thanks bors r=rohany |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Aug 24, 2020
53263: util/logs: request redactable logs by default r=irfansharif a=knz First two commits from #53313 This changes the default value for the `--redactable-logs` flag to `true`. This makes server produce redactable logs by default. Note that `--redactable-logs` only triggers redactable logs if the caller calls `SetupRedactionAndStderrRedirects()`. This is done by e.g. the server code. This means that even with this patch, *unit tests* continue to produce non-redactable logs. This commit also adds telemetry for the enablement of redactable markers, as `server.logging.redactable_logs.{enabled,disabled}`. Fixes #51834. Release note (cli change): The `cockroach start`, `start-single-node` and `demo` command now enable `--redactable-logs` by default. This causes log files to become redactable, so that `cockroach debug merge-log --redact` or `cockroach debug zip --redact` can remove sensitive information out of log files. (Reminder: `cockroach debug zip --redact` only affects *log files*; other items collected by the command can still contain sensitive information) 53295: kvserver: fix race in rangefeed processor setup r=nvanbenschoten a=ajwerner Fixes #53183 Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Andrew Werner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None