-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: bump Pebble to a24bc6c83054489b1bb0d9f53bcdd4ad8ec75977 #53208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though @knz should speak up regarding the upgrade of cockroachdb/errors
. Or you can figure out how to revert that portion of this bump.
yes you should revert that -- the crdb code is not ready for it, you'll get plenty of CI failures. |
a24bc6c sstable: optimize seeks to use next 76afcca db: optimize levelIter for repeated seeks with narrow and monotonic bounds Release note: None
9812d20
to
d15daba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @itsbilal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are getting picked up simply by running Looks like @knz is picking up the same versions of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TFTR! |
bors r+ |
This PR was included in a batch that was canceled, it will be automatically retried |
Build failed (retrying...): |
Build succeeded: |
The concern I had was for |
a24bc6c sstable: optimize seeks to use next
76afcca db: optimize levelIter for repeated seeks with narrow and monotonic bounds
Release note: None