Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: support inexact two-variable comparison implication #53118

Closed
wants to merge 1 commit into from

Conversation

DrewKimball
Copy link
Collaborator

This PR adds support to the partial index predicate implicator for
handling comparisons where both inputs are variables. Previously,
implication could only be accomlished when one of the inputs was a
constant.

Examples:
@1 = @2 => @2 = @1
@1 <> @2 => @2 <> @1
@1 < @2 => @2 > @1
@1 < @2 => @1 <= @2

Release note: None

This PR adds support to the partial index predicate implicator for
handling comparisons where both inputs are variables. Previously,
implication could only be accomlished when one of the inputs was a
constant.

Examples:
`@1 = @2 => @2 = @1`
`@1 <> @2 => @2 <> @1`
`@1 < @2 => @2 > @1`
`@1 < @2 => @1 <= @2`

Release note: None
@DrewKimball DrewKimball requested a review from a team as a code owner August 20, 2020 06:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@DrewKimball DrewKimball requested a review from mgartner August 20, 2020 06:20
@RaduBerinde
Copy link
Member

Hm, isn't this the same with #52996?

@DrewKimball
Copy link
Collaborator Author

Closing as duplicate

@DrewKimball DrewKimball deleted the comp_implication branch May 18, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants