-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add support for IF NOT EXISTS
for ALTER TABLE ADD CONSTRAINT
#53095
Conversation
This commit adds the option `IF NOT EXISTS` to the `ALTER TABLE ADD CONSTRAINT`. With this option pgcode.DuplicateObject will not be raised. Release note (sql change): Add support for `IF NOT EXISTS` option for `ALTER TABLE ADD CONSTRAINT` command.
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
I'm hesitant to accept this because of my concern on the issue. I'll review it once we come to a conclusion there |
+1 to adding this, thanks for the contribution! |
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
2 similar comments
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
bf916c9
to
23b824a
Compare
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
23b824a
to
fbf5cfc
Compare
Thank you for updating your pull request. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There's a better PR (#71257) for the original issue. |
Fixes #53007
This commit adds the option
IF NOT EXISTS
to theALTER TABLE ADD CONSTRAINT
. With this optionpgcode.DuplicateObject
will not be raised.Release note (sql change): Add support for
IF NOT EXISTS
option forALTER TABLE ADD CONSTRAINT
command.