backupccl: refactor backup destination resolution #53060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This is a WIP, but ready for early feedback. I still want to rework some of the naming (e.g. encryptionContext) and need to do general clean up. |
pbardea
force-pushed
the
refactor-backup-dest-resolution
branch
from
05175d1 to
bf760c0
Compare
|
I'm going to implement the TODO on |
|
Did a first pass this LGTM, really like how it cleans up the ever 🎈-ing |
pbardea
force-pushed
the
refactor-backup-dest-resolution
branch
2 times, most recently
from
8cc50ad to
c5f93d5
Compare
|
Cleaned it up a bit - it should be RFAL. |
pbardea
force-pushed
the
refactor-backup-dest-resolution
branch
from
c5f93d5 to
5af66ca
Compare
dt
approved these changes
Aug 20, 2020
pbardea
force-pushed
the
refactor-backup-dest-resolution
branch
from
5af66ca to
1ce0055
Compare
During backup planning we need to resolve the backup destination. This means that we need to: 1. Determine if we're going to resolve to a backup collection or not 2. Determine if we should auto-append 3. Read any encryption options we may need if we determine that we're donig an incremental backup 4. Find the previous backups in the chain if we're doing an incremental backup. Release note: None
pbardea
force-pushed
the
refactor-backup-dest-resolution
branch
from
1ce0055 to
e73db28
Compare
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During backup planning we need to resolve the backup destination. This
means that we need to:
donig an incremental backup
backup.
Release note: None