Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: unskip TestRegistryLifecycle/rollback #53016

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Conversation

spaskob
Copy link
Contributor

@spaskob spaskob commented Aug 19, 2020

The test flakiness was introduced by #52697 and fixed by #52710.

Fixes #52767.

Release note: none.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor

knz commented Aug 19, 2020

There's something odd in the message - you say the flakiness was introduced and fixed in the same PR. How can that be true? I would never have been to observe it from a different PR.

The test flakiness was introduced by #52697and fixed by cockroachdb#52710.

Fixes cockroachdb#52767.

Release note: none.
@spaskob
Copy link
Contributor Author

spaskob commented Aug 19, 2020

Sorry wrong paste.

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@spaskob
Copy link
Contributor Author

spaskob commented Aug 19, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 19, 2020

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@spaskob
Copy link
Contributor Author

spaskob commented Aug 19, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 19, 2020

Build succeeded:

@craig craig bot merged commit 51b0af4 into cockroachdb:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jobs: flake in TestRegistryLifecycle/rollback
3 participants