sql: use the new EXPLAIN infrastructure for UI plans #52956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The statement statistics code buckets statements separately depending on the distribution and vectorization flags. This is not very useful: we normally don't expect these flags to change for the same statement; and the UI doesn't show them separately anyway. In addition, it poses a problem to switching the explain tree (presented to UI) to use the new explain infrastructure: we need to know if we will need the tree upfront (before execbuild). This change removes these flags from the key. The flags are still populated in the `StatementStatisticsKey`. Release note: None
|
This change is |
To support executing plans that were generated with `explain.Factory`, we must not use the same factory for "inner" plans generated by apply joins and recursive CTEs. We modify the functions to pass the exec factory. Note that we were already doing this for cascade planning. Release note: None
This change reworks how the `roachpb.ExplainPlanTreeNode` tree (used by the UI to show statement plans) is populated. We use the new EXPLAIN infrastructure. The main change is that we need to decide upfront if we will need the plan or not. Release note (admin ui change): various improvements to the statement plans in the UI.
rohany
approved these changes
Aug 18, 2020
|
TFTR! |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: don't key statement statistics on distribution/vectorization
The statement statistics code buckets statements separately depending on the
distribution and vectorization flags. This is not very useful: we normally don't
expect these flags to change for the same statement; and the UI doesn't show
them separately anyway. In addition, it poses a problem to switching the explain
tree (presented to UI) to use the new explain infrastructure: we need to know if
we will need the tree upfront (before execbuild).
This change removes these flags from the key. The flags are still populated in
the
StatementStatisticsKey.Release note: None
sql: use the new EXPLAIN infrastructure for UI plans
This change reworks how the
roachpb.ExplainPlanTreeNodetree (used by the UIto show statement plans) is populated. We use the new EXPLAIN infrastructure.
The main change is that we need to decide upfront if we will need the plan or
not.
Release note (admin ui change): various improvements to the statement plans in
the UI.