server: add end-to-end tenant authentication test #52589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit ensures that authentication errors correctly propagate through KV client code. It then adds a new TestTenantUnauthenticatedAccess test that spins up a SQL-only tenant process with an incorrect key codec and ensures that the server fails due to an authentication error from the KV layer.
nvanbenschoten
force-pushed
the
nvanbenschoten/distSenderAuth
branch
from
4a4dee1 to
cd84345
Compare
nvanbenschoten
added a commit
to nvanbenschoten/cockroach
that referenced
this pull request
Aug 10, 2020
Fixes cockroachdb#52360. First two commits from cockroachdb#52589. This commit adds a new restriction to the tenantAuth policy that it accepts no "Admin" KV requests. This prevents tenants from splitting ranges, merging range, rebalancing ranges, or issuing any other KV requests with the `isAdmin` flag that could dictate KV-level distribution decisions. This further mitigates the impact that a compromised tenant SQL process could have on the rest of the cluster.
tbg
approved these changes
Aug 11, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that authentication errors correctly propagate through
KV client code. It then adds a new TestTenantUnauthenticatedAccess test that
spins up a SQL-only tenant process with an incorrect key codec and ensures
that the server fails due to an authentication error from the KV layer.