Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload: tolerate ambiguous commit errors with --tolerate-ambiguous-errors #52555

Closed
wants to merge 1 commit into from

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 10, 2020

Fixes #49865

Release note (cli change): cockroach workload now recognizes the
command-line flag --tolerate-ambiguous-errors to ignore ambiguous
commit errors. This is useful when testing workload during "chaos
testing", when nodes are stopped/restarted ungracefully.

…-errors`

Release note (cli change): `cockroach workload` now recognizes the
command-line flag `--tolerate-ambiguous-errors` to ignore ambiguous
commit errors. This is useful when testing `workload` during "chaos
testing", when nodes are stopped/restarted ungracefully.
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor Author

knz commented Aug 10, 2020

@nvanbenschoten I'm not exactly sure how to test this and verify that it works. Do you have a suggestion?

Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes here LGTM but I'll leave it to you and Nathan to duke it out over #49865. It seems we added this flag to paper over chaos conditions, but we're now seeing ambiguous errors even without chaos? That makes make question the utility of this.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @irfansharif and @nvanbenschoten)

@nvanbenschoten
Copy link
Member

Cross-posting two things from #49865:

Re chaos tests: Like @knz, I was also surprised to see that we were already passing --tolerate-errors in the chaos tests that were hitting ambiguous errors and that we'd now want to pass this new flag to. That indicates that this flag won't help the problem and that errors are making their way back to the test through some other mechanism.

Re non-chaos tests: The fact that we're seeing ambiguous errors under normal circumstances is a problem. I don't think we should paper over it by applying this blindly. Instead, we should try to eliminate such sources of ambiguity (e.g. #52566).

@knz knz marked this pull request as draft August 24, 2020 11:31
@knz knz closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workload: should tolerate 40003 ambiguous error without --tolerate-errors
4 participants