Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: use leased database descriptors, implement database schema changes #52553

Closed
wants to merge 2 commits into from

Conversation

thoszhang
Copy link
Contributor

No description provided.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@thoszhang thoszhang force-pushed the db-cache branch 3 times, most recently from 7040b50 to e0c6d52 Compare August 10, 2020 15:12
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 6 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @lucy-zhang)


pkg/sql/catalog/descs/collection.go, line 216 at r2 (raw file):

Quoted 8 lines of code…
	mutDesc, ok := db.(*sqlbase.MutableDatabaseDescriptor)
	if !ok {
		// TODO (lucy): Here and elsewhere in the Collection, we return a nil
		// descriptor with a nil error if the type cast doesn't succeed, regardless
		// of whether flags.Required is true. This seems like a potential source
		// of bugs.
		return nil, nil
	}

I think if this is nil and the flag is required we should fatal as it is a programming error from the implementation of the physical accessor.


pkg/sql/catalog/descs/collection.go, line 343 at r2 (raw file):

> // TODO (lucy): This logic is quite similar to GetObjectVersion. Think about
> // unifying once we also have support for schemas.
> ```
:pray: 

@asubiotto
Copy link
Contributor

We need to get this PR in pretty soon as it is a multitenant MVP blocker (#52617)

@thoszhang
Copy link
Contributor Author

Moved to #52975.

@thoszhang thoszhang closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants