Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Define @cockroachlabs/crdb-protobuf-client package #52421

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Aug 5, 2020

The main idea is to have reusable protobuf client which can be used
outside of Admin UI.

Package can be published with following command:

yarn publish --access public --no-git-tag-version --patch

Release note: None

@koorosh koorosh requested review from dhartunian and a team August 5, 2020 19:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@koorosh koorosh force-pushed the ui-protobuf-client-package branch from 8482d48 to c0448b2 Compare August 27, 2020 08:22
@koorosh koorosh changed the base branch from master to staging August 27, 2020 13:03
@koorosh koorosh changed the base branch from staging to master August 27, 2020 13:03
@koorosh koorosh force-pushed the ui-protobuf-client-package branch 2 times, most recently from a6036c1 to 9651571 Compare August 27, 2020 16:06
The main idea is to have reusable protobuf client which can be used
outside of Admin UI.

Package can be published with following command:
```
yarn publish --access public --no-git-tag-version --patch
```

Release note: None

Release justification: non production code changes
@koorosh koorosh force-pushed the ui-protobuf-client-package branch from 9651571 to 8ef7ad2 Compare August 28, 2020 13:48
@koorosh
Copy link
Collaborator Author

koorosh commented Aug 31, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Build failed:

@koorosh
Copy link
Collaborator Author

koorosh commented Sep 14, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 14, 2020

Build succeeded:

@craig craig bot merged commit b6a90ac into cockroachdb:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants