bulkio: Correctly handle exhausting retries when reading from HTTP. #52281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
approved these changes
Aug 3, 2020
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r=rohany |
craig bot
pushed a commit
that referenced
this pull request
Aug 4, 2020
51503: rpc: use tenant client/server certs r=nvanbenschoten a=tbg With this PR, tenant SQL servers use tenant client certificates to connect to the tenant server endpoint at the KV layer. They were previously using the KV-internal node certs. No validation is performed as of this PR, but this is the obvious next step. Follow-up work will assertions that make sure that we don't see tenants "accidentally" use the node certs for some operations when they are available (as is typically the case during testing). Finally, there will be some work on the heartbeats exchanged by the RPC context. We don't want a SQL tenant's time signal to ever trigger KV nodes to crash, for example. Touches #47898. Release note: None - cli/flags,config: new flag for tenant KV listen addr - sql: route tenant KV traffic to tenant KV address - roachtest: configure --tenant-addr flag in acceptance/multitenant - rpc: add TenantID to rpc.ContextOptions - security: slight test improvement - rpc: pass TenantID to SecurityContext to CertManager - security: use a single test_certs dir - security: embed certs for a few hard-coded tenants - rpc: *almost* use tenant client certs (on tenants) - rpc: use tenant client/server certs where appropriate 52281: bulkio: Correctly handle exhausting retries when reading from HTTP. r=rohany a=miretskiy Fixes #52279 Return an error if we exhaust the retry budget when reading from HTTP. Release Notes: None Co-authored-by: Tobias Schottdorf <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]>
|
Build failed (retrying...): |
|
bors r-
|
|
Canceled. |
|
yeah; somebody merged a change before this pr.
…On Tue, Aug 4, 2020 at 10:01 AM kena ***@***.***> wrote:
bors r-
this is a legitimate CI failure:
[image: image]
<https://user-images.githubusercontent.com/642886/89302887-bb461b00-d66b-11ea-813b-f15ebb1b3152.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#52281 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANA4FVCL7IN6QFKXZBVVTRDR7AIEJANCNFSM4PTWODNA>
.
|
Return an error if we exhaust the retry budget when reading from HTTP. Release Notes: None
|
bors r=rohany |
This was referenced Aug 13, 2020
|
oops; didn't realize it didn't merge |
|
Build succeeded: |
adityamaru
added a commit
to adityamaru/cockroach
that referenced
this pull request
Aug 26, 2020
PR cockroachdb#52281 fixed a scenario where we would only surface context cancellation errors, but swallow everything else in the HttpResumer. This change simply adds a test reinforcing that we do this. Release note: None Release justification: non-production code changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52279
Return an error if we exhaust the retry budget when reading from HTTP.
Release Notes: None