Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/flags: hide --advrertise-sql-addr from the output of --help #52271

Closed
wants to merge 1 commit into from

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 3, 2020

See discussion in #52266.

Release note: None

@knz knz requested review from bdarnell and Amruta-Ranade August 3, 2020 18:52
@knz knz requested a review from a team as a code owner August 3, 2020 18:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor Author

knz commented Aug 4, 2020

@bdarnell reviewed this PR in #52266 :

As for hiding it from --help in the meantime, I'm not a fan of hidden options unless the support burden is really high. This one is straightforward enough - if you're using both --sql-addr and --advertise-addr, you should probably also use --sql-advertise-addr, and set it using the same logic you used for --advertise-addr.

Closing this PR in favor of clarification in docs.

@knz knz closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants