roachtest: fix release-20.1 roachtests failing due to double-init #52040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @irfansharif, @jlinder, and @nvanbenschoten)
pkg/cmd/roachtest/main.go, line 164 at r1 (raw file):
} // TODO(irfansharif): We could remove this up by directly running `cockroach
[nit] "remove this up"
Fixes cockroachdb#51965 (and all referencing issues). Roachprod clusters running v20.1+ crdb nodes persist this `cluster-bootstrapped` file on disk after explicitly bootstrapping the cluster. Roachprod then uses the existence of this file to avoid doubly bootstrapping the cluster. Given cockroachdb#51897 remains unresolved, master-built roachprod is used to run roachtests against the 20.1 branch. Some of those roachtests test mixed-version clusters that start off at 19.2. Consequently, we manually add this file where roachprod expects to find it for already-initialized clusters. (This is a pretty gross hack, that we should address by addressing cockroachdb#51897.) Release note: None
irfansharif
force-pushed
the
200728.roachprod-init-20.1
branch
from
4638e8f to
d1ddaf5
Compare
irfansharif
commented
Jul 28, 2020
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/cmd/roachtest/main.go, line 164 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] "remove this up"
Done.
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
I don't know what this is. bors r+ |
|
Build failed: |
|
Trying again, though this "Failed to publish files" issue seems persistent (I've seen it on a 20.1 PR as well) bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 29, 2020
52040: roachtest: fix release-20.1 roachtests failing due to double-init r=RaduBerinde a=irfansharif Fixes #51965 (and all referencing issues). Roachprod clusters running v20.1+ crdb nodes persist this `cluster-bootstrapped` file on disk after explicitly bootstrapping the cluster. Roachprod then uses the existence of this file to avoid doubly bootstrapping the cluster. Given #51897 remains unresolved, master-built roachprod is used to run roachtests against the 20.1 branch. Some of those roachtests test mixed-version clusters that start off at 19.2. Consequently, we manually add this file where roachprod expects to find it for already-initialized clusters. (This is a pretty gross hack, that we should address by addressing #51897.) Release note: None Co-authored-by: irfan sharif <[email protected]>
|
Build failed: |
|
bors r+
…On Wed, Jul 29, 2020, 1:57 AM craig[bot] ***@***.***> wrote:
Build failed:
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=2127994&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#52040 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQMN4STBYU7XBLOOFCYNHLR5626FANCNFSM4PK7PKDA>
.
|
|
Build succeeded: |
This was referenced Jul 29, 2020
This was referenced Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51965 (and all referencing issues).
Roachprod clusters running v20.1+ crdb nodes persist this
cluster-bootstrappedfile on disk after explicitly bootstrapping thecluster. Roachprod then uses the existence of this file to avoid doubly
bootstrapping the cluster.
Given #51897 remains unresolved, master-built roachprod is used to run
roachtests against the 20.1 branch. Some of those roachtests test
mixed-version clusters that start off at 19.2. Consequently, we manually
add this file where roachprod expects to find it for already-initialized
clusters. (This is a pretty gross hack, that we should address by
addressing #51897.)
Release note: None