-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachprod: fixup roachprod --sequential
#51893
roachprod: fixup roachprod --sequential
#51893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @irfansharif, @nvanbenschoten, and @petermattis)
pkg/cmd/roachprod/install/cockroach.go, line 145 at r1 (raw file):
// We reserve a few special operations like initializing the cluster, // and setting cluster settings, for node 1.
nit: no comma.
pkg/cmd/roachprod/install/cockroach.go, line 475 at r1 (raw file):
// which prompts CRDB to auto-initialize. For nodes running >=20.1, we // need to explicitly initialize. return !h.useStartSingleNode(vers) && nodes[nodeIdx] == 1 && vers.AtLeast(version.MustParse("v20.1.0"))
Do we want/need the nodes[nodeIdx] == 1
check?
bf77241
to
b7889b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick review!
bors r+
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @petermattis)
pkg/cmd/roachprod/install/cockroach.go, line 145 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
nit: no comma.
Done.
pkg/cmd/roachprod/install/cockroach.go, line 475 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
Do we want/need the
nodes[nodeIdx] == 1
check?
Done. Inlined at caller.
Build failed: |
UI test flake? |
..and the setting of cluster settings for single node clusters. `roachprod start --sequential` was broken in cockroachdb#51329, and the broken-ness outlined in TODOs in cockroachdb#51790. This PR just addresses those TODOs. Fixes cockroachdb#51497 Fixes cockroachdb#51721 Fixes cockroachdb#51738 Fixes cockroachdb#51768 Fixes cockroachdb#51769 Fixes cockroachdb#51776 Release note: None
b7889b0
to
6d6706b
Compare
bors r+ |
Build succeeded: |
..and the setting of cluster settings for single node clusters.
roachprod start --sequential
was broken in #51329, and the broken-nessoutlined in TODOs in #51790. This PR just addresses those TODOs.
Fixes #51497
Fixes #51721
Fixes #51738
Fixes #51768
Fixes #51769
Fixes #51776
Release note: None