Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: improve node liveness failure log, point to docs #51870

Merged
merged 1 commit into from
Jul 28, 2020
Merged

kvserver: improve node liveness failure log, point to docs #51870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pkg/kv/kvserver/node_liveness.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ func (nl *NodeLiveness) StartHeartbeat(
}
return nil
}); err != nil {
log.Warningf(ctx, "failed node liveness heartbeat: %+v", err)
log.Warningf(ctx, heartbeatFailureLogFormat, err)
}

nl.heartbeatToken <- struct{}{}
Expand All @@ -602,6 +602,16 @@ func (nl *NodeLiveness) StartHeartbeat(
})
}

const heartbeatFailureLogFormat = `failed node liveness heartbeat: %+v

An inability to maintain liveness will prevent a node from participating in a
cluster. If this problem persists, it may be a sign of resource starvation or
of network connectivity problems. For help troubleshooting, visit:

https://www.cockroachlabs.com/docs/stable/cluster-setup-troubleshooting.html#node-liveness-issues

`

// PauseHeartbeat stops or restarts the periodic heartbeat depending on the
// pause parameter. When pause is true, waits until it acquires the heartbeatToken
// (unless heartbeat was already paused); this ensures that no heartbeats happen
Expand Down