Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: improve the partial index label in EXPLAIN #51839

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

RaduBerinde
Copy link
Member

This commit moves the "partial index" mention next to the name of the
index.

Release note: None

This commit moves the "partial index" mention next to the name of the
index.

Release note: None
@RaduBerinde RaduBerinde requested a review from mgartner July 23, 2020 16:03
@RaduBerinde RaduBerinde requested a review from a team as a code owner July 23, 2020 16:03
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Nice!

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 23, 2020

Build failed (retrying...):

@RaduBerinde
Copy link
Member Author

bors r+

@RaduBerinde
Copy link
Member Author

This has got to be a record low for the ratio <time making the code change> / <time wasted trying to merge>.

bors r-

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 27, 2020

Build succeeded:

@craig craig bot merged commit 069d328 into cockroachdb:master Jul 27, 2020
@RaduBerinde RaduBerinde deleted the explain-partial-index branch July 31, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants