dump: fix dump-backwards-compatibility remote roachtest #51832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the execution of the cockroach binary from `cockroach` to `./cockroach`. This follows how other CLI roachtests run the binary. Before this commit, this test would fail when run on a GCE roachprod cluster, it now passes. Release note: None
|
This change is |
|
lgtm |
|
TFTR |
|
Build succeeded: |
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the execution of the cockroach binary from
cockroachto./cockroach. This follows how other CLI roachtests runthe binary. Before this commit, this test would fail when run on a GCE
roachprod cluster, it now passes.
Release note: None