sql: remove unnecessary stmtType from explain code #51585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tree.StatementType` is not needed for `EXPLAIN (PLAN)` or `(VEC)`. I believe it is only necessary for `EXPLAIN ANALYZE` (when we actually run the query). This commit removes the plumbing of `stmtType` from the paths where it is not necessary. Release note: None
|
This change is |
yuzefovich
approved these changes
Jul 19, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tree.StatementTypeis not needed forEXPLAIN (PLAN)or(VEC). I believe it is only necessary forEXPLAIN ANALYZE(when weactually run the query).
This commit removes the plumbing of
stmtTypefrom the paths where itis not necessary.
Release note: None