backupccl: add RestoreData processor #51562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
pbardea
force-pushed
the
restore-data
branch
3 times, most recently
from
6644843 to
4767fe6
Compare
|
Friendly ping. |
dt
approved these changes
Jul 27, 2020
| if len(row) != 2 { | ||
| return errors.New("expected input rows to have exactly 2 columns") | ||
| } | ||
| alloc := &sqlbase.DatumAlloc{} |
There was a problem hiding this comment.
nit: could pull this out of the loop so it gets reused as intended.
dt
reviewed
Jul 27, 2020
| @@ -161,6 +161,17 @@ message BackupDataSpec { | |||
| message RestoreSpanEntry { | |||
| optional roachpb.Span span = 1 [(gogoproto.nullable) = false]; | |||
| repeated roachpb.ImportRequest.File files = 2 [(gogoproto.nullable) = false]; | |||
| optional int64 progressIdx = 3 [(gogoproto.nullable) = false]; | |||
There was a problem hiding this comment.
The coordinator will set this in restore_job - it's currently not set right now, but will be in the planning PR.
This commit adds a processor which actually performs the ImportRequest. It has an input which accepts rows with 2 columns that should be sent from SplitAndScatter processors. Each row represents one span that the processor should ingest. The intention is that the spans direcected to a processor on a given node have their leaseholder colocated on the same node (this work is done in the SplitAndScatter processor). All that remains is to send a request to ingest the data and stream back its progress to the coordinator upon completion. Release note: None
|
TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a processor which actually performs the ImportRequest.
It has an input which accepts rows with 2 columns that should be sent
from SplitAndScatter processors. Each row represents one span that the
processor should ingest. The intention is that the spans direcected to a
processor on a given node have their leaseholder colocated on the same
node (this work is done in the SplitAndScatter processor). All that
remains is to send a request to ingest the data and stream back its
progress to the coordinator upon completion.
Part of #40239.
Release note: None