sql: ensure SQLSTATE 42710 on secondary errors #51406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an object that collides with another, we have to perform another lookup to get the kind of object that it collided with. If an error occurs during this second stage, we want the error to propose SQLSTATE "Duplicate object" (42710) to the client if there is no pgcode in the error object already. Release note: None
|
This change is |
|
@rohany maybe add to your checklist for SQL error handling to verify pg codes are added where relevant? |
|
Good catch. Sorry, I wasn't aware that there was an equivalent wrap function for pgerrors LGTM |
|
bors r=rohany |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #51260
When creating an object that collides with another, we have to perform
another lookup to get the kind of object that it collided with.
If an error occurs during this second stage, we want the error to
propose SQLSTATE "Duplicate object" (42710) to the client if there is
no pgcode in the error object already.
Release note: None