sql: change volatility of timezone with TIME and TIMETZ to stable #51037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
mgartner
force-pushed
the
timetz-volatility
branch
from
6a3c80e to
68d7bd2
Compare
otan
reviewed
Jul 7, 2020
pkg/sql/sem/builtins/builtins.go
Outdated
| @@ -2407,7 +2407,8 @@ may increase either contention or retry errors, or both.`, | |||
| ), | |||
|
|
|||
| // https://www.postgresql.org/docs/9.6/functions-datetime.html | |||
| "timezone": makeBuiltin(defProps(), | |||
| "timezone": makeBuiltin( | |||
| tree.FunctionProperties{IgnoreVolatilityCheck: true}, | |||
There was a problem hiding this comment.
do you mind adding a comment linking to the issue here so it's easier to reconcile the justification?
also wondering if this ignore should be at the overload level, leave that up to you though.
There was a problem hiding this comment.
Ya I think it should be at the overload level because that's where volatility is defined. I'll make the change.
RaduBerinde
approved these changes
Jul 7, 2020
The `timezone(STRING, TIME)` and `timezone(STRING, TIMETZ)` function
overloads were originally marked as volatile to copy Postgres's
volatility for the `timezone(STRING, TIMETZ)` overload (Postgres does
not implement `timezone (STRING, TIME)`.
Postgres's volatility settings for all overloads of `timezone` are
below.
Name | Argument data types | Volatility
----------+---------------------------------------+------------------
timezone | interval, time with time zone | immutable zone
timezone | interval, timestamp with time zone | immutable
timezone | interval, timestamp without time zone | immutable
timezone | text, time with time zone | volatile zone
timezone | text, timestamp with time zone | immutable
timezone | text, timestamp without time zone | immutable
This single overload is singled out as volatile by Postgres because it
is dependent on C's `time(NULL)`. See the Postgres commit originally
marking this overload volatility, and the lines of code showing the
dependence:
postgres/postgres@35979e6
https://github.com/postgres/postgres/blob/ac3a4866c0bf1d7a14009f18d3b42ffcb063a7e9/src/backend/utils/adt/date.c#L2816
CRDB does not have the same issue. All `timezone` overloads have the
same volatility, stable. This commit marks them as such.
Additional context: cockroachdb#48756 (comment)
This commit also moves the `IgnoreVolatilityCheck` field from function
definitions to overloads. This allows overloads of the same function to
be ignored when asserting that the volalitity of an overload matches
Postgres's assigned volatility.
Release note: None
mgartner
force-pushed
the
timetz-volatility
branch
from
68d7bd2 to
f949158
Compare
|
bors r+ |
Build failed (retrying...) |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: change volatility of timezone with TIME and TIMETZ to stable
The
timezone(STRING, TIME)andtimezone(STRING, TIMETZ)functionoverloads were originally marked as volatile to copy Postgres's
volatility for the
timezone(STRING, TIMETZ)overload (Postgres doesnot implement
timezone (STRING, TIME).Postgres's volatility settings for all overloads of
timezonearebelow.
This single overload is singled out as volatile by Postgres because it
is dependent on C's
time(NULL). See the Postgres commit originallymarking this overload volatility, and the lines of code showing the
dependence:
postgres/postgres@35979e6
https://github.com/postgres/postgres/blob/ac3a4866c0bf1d7a14009f18d3b42ffcb063a7e9/src/backend/utils/adt/date.c#L2816
CRDB does not have the same issue. All
timezoneoverloads have thesame volatility, stable. This commit marks them as such.
Additional context: #48756 (comment)
This commit also moves the
IgnoreVolatilityCheckfield from functiondefinitions to overloads. This allows overloads of the same function to
be ignored when asserting that the volalitity of an overload matches
Postgres's assigned volatility.
Release note: None